RFR: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set [v8]

[Xin Liu]

On Wed, 24 Feb 2021 12:09:23 GMT, Evgeny Astigeevich <github.com+42899633+eastig at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
>>   
>>   add comments and hoist ResourceMark
>
> test/hotspot/gtest/utilities/test_ostream.cpp line 69:
> 
>> 67: }
>> 68: 
>> 69: static void test_stringStream_tr_delete(stringStream* ss) {
> 
> I think this is a unit test for `StringUtils::replace_no_expand`. It checks that the function can be used to remove substrings. There is no dependency on `stringStream`. Any string can be used.
> Could you please move the test to `test_stringUtils.cpp`?

yes, let me move it to test_stringUtils.cpp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2178