RFR: 8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload

[Aleksey Shipilev]

On Thu, 25 Feb 2021 09:50:27 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> I also find it a bit weird to even have the assert on this path, as we tested all cases in the if-chain before, and the only path to this assert is through `lt` and `le` -- which is `is_less`? Maybe I am missing something, though.
>
>> I also find it a bit weird to even have the assert on this path, as we tested all cases in the if-chain before, and the only path to this assert is through `lt` and `le` -- which is `is_less`? Maybe I am missing something, though.
> 
> I kept it because of the !fail->_con part of the assert. I kept the whole assert and move it around because I'm lazy, I guess.

That's fine. Keep the comment, though?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2707