RFR: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set [v9]
Tobias Hartmann
thartmann at openjdk.java.net
Fri Feb 26 10:49:42 UTC 2021
On Thu, 25 Feb 2021 08:56:14 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> Add a flag _suppress_cr to outputStream. outstream objects won't emit any CR if it's set.
>> Correct TypeInstPtr::dump2 to make sure it only emits klass name once.
>> Remove the comment because Klass::oop_print_on() has emitted the address of oop.
>>
>> Before:
>> 689 ConP === 0 [[ 821 ]] Oop:java/lang/Stringjava.lang.String
>> {0x000000010159d7c8} - klass: public final synchronized 'java/lang/String'
>> - string: "a"
>> :Constant:exact *
>>
>> After:
>> 689 ConP === 0 [[ 821 ]] Oop:java.lang.String {0x000000010159d7c8} - klass: public final synchronized 'java/lang/String' - string: "a":Constant:exact *
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>
> 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
>
> update comments based on the review feedbacks.
> move the unittest to test_stringUtil.cpp.
Looks good to me.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2178
More information about the hotspot-compiler-dev
mailing list