RFR: 8258961: devirtualize SafePointNode::jvms() and hide out set_jvms()

[Tobias Hartmann]

On Mon, 28 Dec 2020 09:48:29 GMT, Xin Liu <xliu at openjdk.org> wrote:

> SafePointNode::jvms() declares virtual but has never been overridden. It seems unnecessary.
> The member variable _jvms declares 'JVMState* const', but set_jvms() updates its value anyway.
> Geting rid of the const qualifier and hides if out using protected.

Changes requested by thartmann (Reviewer).

src/hotspot/share/opto/callnode.hpp line 336:

> 334:   JVMState* _jvms;      // Pointer to list of JVM State objects
> 335:   void set_jvms(JVMState* s) {
> 336:     _jvms = s;  // override const attribute in the accessor

The comment should be adjusted since `_jvms` is not const anymore.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1899