RFR: 8258751: Improve ExceptionHandlerTable dump

[Tobias Hartmann]

On Wed, 23 Dec 2020 10:16:29 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:

> In addition to PC offset, print the real PC as well if available when
> dumping the ExceptionHandlerTable, as it's more convenient and readable
> for debugging or other activities.
> 
> Note that compilers might dump the ExceptionHandlerTable before method
> registered. See functions emit_code_body() and fill_buffer(). However,
> real PC is not ready yet during these phases since the generated code is
> not installed. In such scenarios, the real PC is not printed.
> 
> The example below shows how the dump information would be changed after
> applying this patch.
>   BEFORE:
>     ExceptionHandlerTable (size = 40 bytes)
>     catch_pco = 392 (2 entries)
>       bci 8 at scope depth 0 -> pco 184
>       bci 19 at scope depth 0 -> pco 124
>   AFTER:
>     ExceptionHandlerTable (size = 40 bytes)
>     catch_pco = 392 (pc=0x0000ffff818f13c8, 2 entries)
>       bci 8 at scope depth 0 -> pco 184 (pc=0x0000ffff818f12f8)
>       bci 19 at scope depth 0 -> pco 124 (pc=0x0000ffff818f12bc)

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1877