[jdk16] RFR: 8258619: -XX:CompileCommand=blackhole, * should only accept empty static methods

Mon Jan 4 09:45:00 UTC 2021

On Thu, 17 Dec 2020 17:58:12 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> In JDK-8257827 CSR, a further comment was raised about changing the semantics of the method. This allegedly introduces the conformance problem. While it is still an open question where the conformance problem is real, we can sidestep the entire issue by allowing only empty static methods to be blackholed. This eliminates any behavioral difference: empty methods have no side effects, and static methods do not need any null checks.
> 
> This change eliminates a lot of new code added by original JDK-8252505 push, mostly now-useless testing code. It adds two more tests that verify that non-empty and non-static methods are properly rejected.

Copyrights should be updated to 2021. Otherwise looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/45