RFR: 8255216: ciEnv::_break_at_compile isn't in use
Tobias Hartmann
thartmann at openjdk.java.net
Tue Jan 5 09:03:04 UTC 2021
On Thu, 17 Dec 2020 18:35:53 GMT, Dan <github.com+7991079+danlemmond at openjdk.org> wrote:
>> src/hotspot/share/compiler/compileBroker.cpp line 2227:
>>
>>> 2225: }
>>> 2226:
>>> 2227: should_break = directive->BreakAtExecuteOption || task->check_break_at_flags();
>>
>> CompileTask::check_break_at_flags is dead code too, and CIBreakAtOSR, CIBreakAt
>> they are all defunct right now.
>
> I wasn't sure whether or not we wanted to roll the removal of all dead code into this issue or just _break_at_compile. The JBS issue specifically mentions _break_at_compile so that's what I removed here - can expand to do other stuff if you think it's a good idea.
I think it's fine to remove all that dead code with this issue
-------------
PR: https://git.openjdk.java.net/jdk/pull/1806
More information about the hotspot-compiler-dev
mailing list