RFR: 8258961: devirtualize SafePointNode::jvms() and hide out set_jvms() [v2]

[Xin Liu]

On Mon, 4 Jan 2021 07:19:55 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8258961: devirtualize SafePointNode::jvms() and hide out set_jvms()
>>   
>>   devirtualize SafePointNode::jvms(). We can't hide the member variable _jvms
>>   because it is exposed to HotSpot Servicability agent. keeping the qualifier
>>   const for the same resaon.
>
> src/hotspot/share/opto/callnode.hpp line 336:
> 
>> 334:   JVMState* _jvms;      // Pointer to list of JVM State objects
>> 335:   void set_jvms(JVMState* s) {
>> 336:     _jvms = s;  // override const attribute in the accessor
> 
> The comment should be adjusted since `_jvms` is not const anymore.

thank you for reviewing this.   Vladimir helped me to understand the hotspot Servicability agent thing, which needs to access this field. I have to revert this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1899