RFR: 8258857: Zero: non-PCH release build fails after JDK-8258074 [v2]

Hao Sun github.com+16932759+shqking at openjdk.java.net
Tue Jan 5 14:30:55 UTC 2021


On Tue, 5 Jan 2021 12:03:05 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Header 'runtime/globals_shared.hpp' should be kept
>>   
>>   Header 'runtime/globals_shared.hpp' is kept even though
>>   'compiler/compiler_globals_pd.hpp' already includes it, because
>>   'compiler_globals.hpp' uses the DECLARE_FLAGS macro, which is defined by
>>   'runtime/globals_shared.hpp', and it should be included directly.
>>   
>>   Besides, update the copyright year to 2021.
>>   
>>   Change-Id: Ia355f3b6e98b495dc265093e71b2d1fec1ca45ca
>>   CustomizedGitHooks: yes
>
> Marked as reviewed by jiefu (Committer).

Thanks for your reviews! @DamonFool @iklam @shipilev 

The pre-submit tests were passed except the GC one which is not related to this patch. I suppose this patch is ready to be merged now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1894


More information about the hotspot-compiler-dev mailing list