RFR: 8258961: devirtualize SafePointNode::jvms() and hide out set_jvms() [v2]
Tobias Hartmann
thartmann at openjdk.java.net
Wed Jan 6 06:58:58 UTC 2021
On Tue, 5 Jan 2021 10:11:11 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> SafePointNode::jvms() declares virtual but has never been overridden. It seems unnecessary.
>> The member variable _jvms declares 'JVMState* const', but set_jvms() updates its value anyway.
>> Geting rid of the const qualifier and hides if out using protected.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>
> 8258961: devirtualize SafePointNode::jvms() and hide out set_jvms()
>
> devirtualize SafePointNode::jvms(). We can't hide the member variable _jvms
> because it is exposed to HotSpot Servicability agent. keeping the qualifier
> const for the same resaon.
Marked as reviewed by thartmann (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/1899
More information about the hotspot-compiler-dev
mailing list