[jdk16] RFR: 8258384: AArch64: SVE verify_ptrue fails on some tests [v2]

Ningsheng Jian njian at openjdk.java.net
Mon Jan 11 07:34:05 UTC 2021


On Tue, 5 Jan 2021 10:40:11 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Ningsheng Jian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year to 2021.
>
> src/hotspot/os_cpu/linux_aarch64/os_linux_aarch64.cpp line 252:
> 
>> 250:                                 pc, info, NULL, NULL, 0, 0);
>> 251:         va_end(detail_args);
>> 252:       }
> 
> I'm not sure it is ok to revert this code. The fix this is part of (for JDK-8255711) was provided explicitly to re-organize the flow of control for handling of fatal errors. Reverting this code appears to undermine the goal of that issue. I would like to get Thomas Stuefe's (@tstuefe) opinion on whether it is appropriate to abort the JVM here vs returning false before accepting this specific change.

Thank you Thomas. I have removed the change from my patch. Would you mind taking another look and approving this patch @adinn ?

-------------

PR: https://git.openjdk.java.net/jdk16/pull/50


More information about the hotspot-compiler-dev mailing list