RFR: 8257709: C1: Double assignment in InstructionPrinter::print_stack

Aleksey Shipilev shade at openjdk.java.net
Mon Jan 11 11:23:09 UTC 2021


On Mon, 11 Jan 2021 08:33:27 GMT, Sergey Platonov <github.com+6061213+sergey-platonov at openjdk.org> wrote:

>> src/hotspot/share/c1/c1_InstructionPrinter.cpp line 242:
>> 
>>> 240:     fill_to(start_position, ' ');
>>> 241:     output()->print("locks [");
>>> 242:     for (int i = 0; i < stack->locks_size(); ++i) {
>> 
>> I would prefer to keep `i++`, as in old code, unless it fixes something I don't quite see.
>
> Done. Can you, please, create an issue, so I can mention it here?

I did already, see https://github.com/openjdk/jdk/pull/1519#issuecomment-738180725.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1519


More information about the hotspot-compiler-dev mailing list