[jdk16] RFR: 8259061: C2: assert(found) failed: memory-writing node is not placed in its original loop or an ancestor of it

Mon Jan 11 12:57:04 UTC 2021

On Mon, 11 Jan 2021 12:27:18 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> Remove assertion that is too general, that is, it can fail on compilations where C2 generates correct code otherwise.
> 
> The assertion was introduced in [JDK-8255763](https://bugs.openjdk.java.net/browse/JDK-8255763) to prevent potential miscompilations in the case of irreducible CFGs, and will be reconsidered in [JDK-8258894](https://bugs.openjdk.java.net/browse/JDK-8258894) where the general case is addressed.
> 
> Tested by building (release and debug) on different platforms.

That's reasonable. Looks good to me!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/101