RFR: 8257709: C1: Double assignment in InstructionPrinter::print_stack [v2]

Sergey Platonov github.com+6061213+sergey-platonov at openjdk.java.net
Mon Jan 11 14:14:24 UTC 2021


On Mon, 11 Jan 2021 11:39:56 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Sergey Platonov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into fix/hotspot-possible-ub
>>  - 8257709: C1: Double assignment in InstructionPrinter::print_stack
>>    
>>    There is currently a minor bug (just a typo, actually) in the hotspot, leading
>>    to undefined behavior.
>>    Issue: JDK-8257709: C1: Double assignment in InstructionPrinter::print_stack
>
> Looks good.

> ...ah, and maybe merge from `master` to get all the recent fixes. Current tests might fail on known issues. Not that it is necessary for a simple issue like this, but it helps to learn the contribution ropes in this project.

Done! Will commits be squashed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1519


More information about the hotspot-compiler-dev mailing list