RFR: 8257709: C1: Double assignment in InstructionPrinter::print_stack [v2]
Aleksey Shipilev
shade at openjdk.java.net
Tue Jan 12 11:03:53 UTC 2021
On Mon, 11 Jan 2021 14:28:17 GMT, Sergey Platonov <github.com+6061213+sergey-platonov at openjdk.org> wrote:
>>> > ...ah, and maybe merge from `master` to get all the recent fixes. Current tests might fail on known issues. Not that it is necessary for a simple issue like this, but it helps to learn the contribution ropes in this project.
>>>
>>> Done! Will commits be squashed?
>>
>> Yes, bots would squash the commits during integration. You don't need to rebase or do anything else Git-wise. Once testing is clean, you can say `/integrate`, as bots suggested.
>
>> > > ...ah, and maybe merge from `master` to get all the recent fixes. Current tests might fail on known issues. Not that it is necessary for a simple issue like this, but it helps to learn the contribution ropes in this project.
>> >
>> >
>> > Done! Will commits be squashed?
>>
>> Yes, bots would squash the commits during integration. You don't need to rebase or do anything else Git-wise. Once testing is clean, you can say `/integrate`, as bots suggested.
>
> Great! Thank you for your help, Aleksey!
If you go an look at "Checks" tab, you will see it says that everything is green. You can say `/integrate` now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1519
More information about the hotspot-compiler-dev
mailing list