[jdk16] RFR: 8259641: C2: assert(early->dominates(LCA)) failed: early is high enough

[Christian Hagedorn]

On Fri, 15 Jan 2021 08:18:07 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/loopopts/TestBrokenAntiDependenceWithPhi.java line 32:
>> 
>>> 30:  *
>>> 31:  */
>>> 32: 
>> 
>> You could move the test into the `compiler.loopopts` package.
>
> Sure but I usually don't (so they are a several tests without it). Why is it important?

I've just seen that the majority of the compiler tests are in a package. But I'm not sure if it required. Probably not. So I'm fine with how it is now.

>> test/hotspot/jtreg/compiler/loopopts/TestBrokenAntiDependenceWithPhi.java line 30:
>> 
>>> 28:  *
>>> 29:  * @run main/othervm -Xcomp -XX:CompileOnly=TestBrokenAntiDependenceWithPhi TestBrokenAntiDependenceWithPhi
>>> 30:  *
>> 
>> Empty line can be removed
>
> Which of the lines do you suggest removing? One that starts with a *?

I've meant the very the last one but it's a minor detail. No need to update it just for that.

-------------

PR: https://git.openjdk.java.net/jdk16/pull/121