RFR: 8258961: move some fields of SafePointNode from public to protected [v5]

Tobias Hartmann thartmann at openjdk.java.net
Mon Jan 18 08:00:50 UTC 2021


On Fri, 15 Jan 2021 02:13:19 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Declare VMStructs is a friend of SafePointNode so we can move some fields from public zone to protected zone. 
>> Clean up the forward declaration section in callnode.hpp. Lock/Unlock Nodes are subclasses of AbstractLockNode.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8258961: move some fields of SafePointNode from public to protected
>   
>   revert code change to devirtualize Node::jvms().
>   There are 3 nodes override jvms() --  SafePointNode, MachSafePointNode and
>   MachHalt. It does not make sense to devirtualize it because we have to do
>   non-trivial dispatch based on types in Node::jvms(). It is not worth it.

Looks reasonable to me but @vnkozlov should also review this again.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1899


More information about the hotspot-compiler-dev mailing list