RFR: 8258961: move some fields of SafePointNode from public to protected [v5]
Xin Liu
xliu at openjdk.java.net
Mon Jan 18 22:44:50 UTC 2021
On Mon, 18 Jan 2021 22:32:32 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8258961: move some fields of SafePointNode from public to protected
>>
>> revert code change to devirtualize Node::jvms().
>> There are 3 nodes override jvms() -- SafePointNode, MachSafePointNode and
>> MachHalt. It does not make sense to devirtualize it because we have to do
>> non-trivial dispatch based on types in Node::jvms(). It is not worth it.
>
> Looks good.
>
> Latest version passed hs-tier1-3 testing.
Thanks for all reviewers.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1899
More information about the hotspot-compiler-dev
mailing list