RFR: 8259928: compiler/{aot,jvmci} tests fail with -Xint

[Igor Ignatyev]

On Tue, 19 Jan 2021 19:12:32 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> I was getting Zero VM close to run tier1, and before that I wanted to see that tier{1,2} pass with -Xint. Some test are failing due to timeouts, but compiler/{aot,jvmci} tests cannot run with -Xint at all. (Zero avoids this by not having VM feature flags "aot" and "jvmci").
>> 
>> Additional testing:
>>  - [x] `compiler/aot`, `compiler/jvmci` with `TEST_VM_OPTS=-Xint` (now disabled)
>>  - [x] `compiler/aot`, `compiler/jvmci` with default options (still run and pass)
>
> I would like to hear @iignatev opinion on this. `vm.aot` and `vm.jvmci` are checks for presence of JVMCI and AOT in JDK build. And you added VM flag check.
> In general I am fine with it because it avoids updating a lot of tests.

I highly doubt we need to update tests within `hotspot/compiler` directory to ignore obviously incompatible configuration, `-Xint`. they are compiler tests by definitions and having all of them saying `@requires  vm.compMode != "Xint"` (or its equivalent) would be, to say the least, strange.

as of the change, Vladimir is right, `vm.aot` and `vm.jvmci` properties represent build compatibility, and one can still enable jvmci with `-Xint` (granted it won't be used, but that's beyond the point here) hence it shouldn't depend on `Xint`. alternative if we change hotspot to disable jvmci flags when one specifies `Xint` or reports them as conflicted, then your changes would be fine. as wrt AOT, I actually see inability to use AOT together w/ -Xint as a product bug.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2132