RFR: 8255216: Change _directive->BreakAtCompileOption to env()->break_at_compile() [v6]

[Vladimir Kozlov]

On Thu, 21 Jan 2021 18:05:20 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Dan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove additional _directive->BreakAtCompileOption calls
>>   
>>   Repurpose to env()->break_at_compile()
>
> Good.

> Currently ciEnv->break_at_compile() is set if directive->BreakAtExecuteOption || task->check_break_at_flags();
> It doesn't consider `C->directive()->BreakAtCompileOption`. IMHO, [this line](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compileBroker.cpp#L2226) should include `|| directive->BreakAtCompileOption`.

Okay. This is totally messed up :(

BreakAtExecuteOption should be only used in https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/output.cpp#L376
to set break point in compiled code.

Pointed [compileBroker.cpp#L2226](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compileBroker.cpp#L2226) line should use BreakAtCompileOption instead of BreakAtExecuteOption.
@danlemmond you need additional change in compileBroker.cpp to replace BreakAtExecuteOption with BreakAtCompileOption.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1806