RFR: 8259922 MethodHandles.collectArguments does not follow its documentation [v2]

Johannes Kuhn github.com+652983+dasbrain at openjdk.java.net
Fri Jan 22 00:33:16 UTC 2021


> Add explicit range check to `MethodHandles.collectArgumentsCheck`.  
> Added test case that exercises all cases.
> 
> This is a behavioral change, from throwing an unspecified exception to throwing an IllegalArgumentException, as specified.  
> No spec change needed, as the IllegalArgumentException is already specified to be thrown in those cases.
> 
> Feel free to suggest a better place for the tests.

Johannes Kuhn has updated the pull request incrementally with one additional commit since the last revision:

  Implement suggestions by Mandy Chung.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2171/files
  - new: https://git.openjdk.java.net/jdk/pull/2171/files/4f74e2df..f01fefaa

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2171&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2171&range=00-01

  Stats: 179 lines in 3 files changed: 82 ins; 95 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2171.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2171/head:pull/2171

PR: https://git.openjdk.java.net/jdk/pull/2171


More information about the hotspot-compiler-dev mailing list