[jdk16] RFR: 8260284: C2: assert(_base == Int) failed: Not an Int

Christian Hagedorn chagedorn at openjdk.java.net
Fri Jan 22 14:40:56 UTC 2021


On Fri, 22 Jan 2021 14:16:35 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> `PhaseIterGVN::no_dependent_zero_check()` does not handle the case when the divisor `n->in(2)` is top when a Div/Mod node is dying. As a result, we hit the assertion in `is_int()` because the type is top.
>> 
>> The fix is straight forward to handle this case and just return false to avoid any further redundant optimization on a dead node.
>> 
>> Thanks,
>> Christian
>
> Looks good to me.

Thank you Tobias for your review!

-------------

PR: https://git.openjdk.java.net/jdk16/pull/129


More information about the hotspot-compiler-dev mailing list