RFR: 8251462: Remove legacy compilation policy [v4]

[Igor Veresov]

On Wed, 20 Jan 2021 19:51:11 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Check legacy flags validity before deriving flag values for emulation mode.
>
> src/hotspot/share/compiler/compilerDefinitions.hpp line 234:
> 
>> 232:   static bool is_interpreter_only() {
>> 233:     return Arguments::is_interpreter_only() || TieredStopAtLevel == CompLevel_none;
>> 234:   }
> 
> Can you move these functions after has_*() functions? They are used before.

Right now has_() functions are defined before uses. Do you want them to be after the uses? Please confirm.

> src/hotspot/share/compiler/compilerDefinitions.hpp line 179:
> 
>> 177:   }
>> 178:   // Is the JVM in a configuration that permits only c2-compiled methods?
>> 179:   // JVMCI compiler replaces C2.
> 
> The comment `JVMCI compiler replaces C2.` should be removed or moved to `is_jvmci_compiler_only()` where it is make more sense.

I removed the comment, it does seem to be out of context. I'm not sure why I put it there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1985