RFR: 8260338: Some fields in HaltNode is not cloned [v2]

Xin Liu xliu at openjdk.java.net
Mon Jan 25 08:16:43 UTC 2021


On Mon, 25 Jan 2021 07:49:57 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> I got strange log as following. Contents in `CodeString` is garbled. It seems not to be initialized.
>> 
>> [3.155s][trace][codestrings ] Created CodeString [ dエ・] (0x7f3804a150)
>> 
>> `HaltNode` has two fields - `_reachable` and `_halt_reason`, but they would not be cloned at Node::clone.
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert change for node.cpp

LGTM, but still need a reviewer's approval.

-------------

Marked as reviewed by xliu (no project role).

PR: https://git.openjdk.java.net/jdk/pull/2213


More information about the hotspot-compiler-dev mailing list