RFR: 8259822: [PPC64] Support the prefixed instruction format added in POWER10
Kazunori Ogata
ogatak at openjdk.java.net
Tue Jan 26 19:20:47 UTC 2021
On Thu, 21 Jan 2021 01:19:02 GMT, Corey Ashford <github.com+51754783+CoreyAshford at openjdk.org> wrote:
>> The POWER10 processor, which implements Power ISA 3.1 [1], supports new instruction formats where an instruction takes two 32bit words. The first word is called prefix, and the instructions with prefix are called prefixed instructions. With more bits in opcode and operand fields, POWER10 supports larger immediate value in an operand, as well as many new instructions.
>>
>> This is the first changes to handle prefixed instructions, and this adds support of prefixed addi (= paddi) instruction as an example of prefix usage. paddi accepts 34bit immediate value, while original addi accepts 16bit value.
>>
>> [1] https://ibm.ent.box.com/s/hhjfw0x0lrbtyzmiaffnbxh2fuo0fog0
>
> src/hotspot/cpu/ppc/assembler_ppc.hpp line 1543:
>
>> 1541: }
>> 1542: }
>> 1543: static bool is_pli(const int* p) { return is_paddi(p, true); }
>
> is_pli() is defined, but not used, as far as I can tell.
It is just intended to show a usage of the second argument of is_paddi(const int* p, bool is_pli = false). Is it unnecessary, i.e., self-evident?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2095
More information about the hotspot-compiler-dev
mailing list