RFR: 8258894: C2: Forbid GCM to move stores into loops [v2]

[Tobias Hartmann]

On Tue, 26 Jan 2021 17:42:17 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use NOT_DEBUG_RETURN in PhaseCFG verification functions
>>   
>>   Move is_memory_writer() test into PhaseCFG::verify_memory_writer_placement(),
>>   mark the function as NOT_DEBUG_RETURN, and make it independent of the PRODUCT
>>   flag. Apply the same refactoring to PhaseCFG::verify(), for consistency.
>>   Simplify callers of both functions accordingly.
>
> Nice.

Thanks for the clarifications!

> Yes, but triggering failures would require JDK-8257146, which is blocked by this issue, to be integrated. I propose to add StressGCM to the tests later in JDK-8257146. Does that make sense?

Yes, that makes sense.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2140