RFR: 8256438: AArch64: Implement match rules with ROR shift register value

[Andrew Haley]

On 1/28/21 9:30 AM, Andrew Haley wrote:
> On 1/28/21 1:50 AM, Eric Liu wrote:
>>
>> Ping
>>
>> -------------
>>
>> PR: https://git.openjdk.java.net/jdk/pull/1858
> 
> I'm reviewing it now.

Looks basically OK, but was tough to review because of the flags and
comments cleanup that made the diff hard to read.

An oddity. For rotations we have:

  match(Set dst (AndI src1 (XorI(RotateRight src2 src3) src4)));

but for all other shifts we have:

  match(Set dst (AndL src1 (XorL(RShiftL src2 src3) src4)));

That is to say, the other shifts have a type suffix. This doesn't look
right. Do you know what is going on?

Otherwise, this looks OK.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671