[jdk16] RFR: 8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop [v8]

Nils Eliasson neliasso at openjdk.java.net
Thu Jan 28 11:38:47 UTC 2021


On Thu, 28 Jan 2021 02:24:06 GMT, Wang Huang <whuang at openjdk.org> wrote:

>> The reason is :
>> 
>>   BasicType t = store->as_Mem()->memory_type();
>>   const char* fill_name;
>>   if (msg == NULL &&
>>       StubRoutines::select_fill_function(t, false, fill_name) == NULL) {
>>     msg = "unsupported store";
>>     msg_node = store;
>>   }
>> 
>> If the `store` is a `StoreVectorNode` ,the `BasicType` is `T_VOID`. It seems that we don't need to intrinsify a `StoreVectorNode` filling here.
>> 
>> I add a new case here to avoid mistake:
>>   case T_NARROWOOP:
>>   case T_NARROWKLASS:
>>   case T_ADDRESS:
>> +  case T_VOID:
>>     // Currently unsupported
>>     return NULL;
>
> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add missing summary and test name

Looks good.

-------------

Marked as reviewed by neliasso (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/132


More information about the hotspot-compiler-dev mailing list