RFR: 8260577: Unused code in AbstractCompiler after Shark compiler removal [v2]

Vladimir Kozlov kvn at openjdk.java.net
Thu Jan 28 16:47:44 UTC 2021


On Thu, 28 Jan 2021 10:11:02 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> After removal of the Shark compiler with [JDK-8171853](https://bugs.openjdk.java.net/browse/JDK-8171853) in JDK 10, some methods in AbstractCompiler are unused.
>> 
>> Thanks,
>> Tobias
>
> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed CICompileNatives and CICompileOSR

Both flags are not related to Shark. I use `CICompileOSR=false` very frequently during debugging to avoid C2 OSR compilations:
http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/file/062bd42c5e2b/src/share/vm/runtime/globals.hpp#l2403

Revert CICompileOSR back to platform independent and keep both flags.
I agree with removal of functions which always return `true`.

-------------

Changes requested by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2281


More information about the hotspot-compiler-dev mailing list