RFR: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled [v7]

Nils Eliasson neliasso at openjdk.java.net
Fri Jan 29 16:38:41 UTC 2021


On Fri, 29 Jan 2021 04:14:03 GMT, 王超 <github.com+25214855+casparcwang at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8260473
>> 
>> Function "PhaseVector::expand_vunbox_node" creates a LoadNode, but forgets to make the LoadNode to pass gc barriers.
>> 
>> 
>> Testing: all Vector API related tests have passed.
>
> 王超 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright date

src/hotspot/share/opto/vector.cpp line 419:

> 417:     Node* vec_field_ld;
> 418:     {
> 419:       DecoratorSet decorators = C2_READ_ACCESS | C2_CONTROL_DEPENDENT_LOAD | IN_HEAP;

C2_READ_ACCESS will be set by "bs->load_at" so you can skip that. 
MO_UNORDERED is missing. That corresponds to "MemNode::unordered" in the original code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2253


More information about the hotspot-compiler-dev mailing list