RFR: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled [v7]

Vladimir Ivanov vlivanov at openjdk.java.net
Fri Jan 29 16:46:43 UTC 2021


On Fri, 29 Jan 2021 16:35:39 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> 王超 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix the copyright date
>
> src/hotspot/share/opto/vector.cpp line 419:
> 
>> 417:     Node* vec_field_ld;
>> 418:     {
>> 419:       DecoratorSet decorators = C2_READ_ACCESS | C2_CONTROL_DEPENDENT_LOAD | IN_HEAP;
> 
> C2_READ_ACCESS will be set by "bs->load_at" so you can skip that. 
> MO_UNORDERED is missing. That corresponds to "MemNode::unordered" in the original code.

`C2_CONTROL_DEPENDENT_LOAD` is also redundant (though original code does that): it's just a plain load from a final instance field).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2253


More information about the hotspot-compiler-dev mailing list