RFR: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled [v4]

王超 github.com+25214855+casparcwang at openjdk.java.net
Sat Jan 30 12:18:41 UTC 2021


On Fri, 29 Jan 2021 16:47:53 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> > As far as I can see, during the parse phase, GraphKit contains the jvm state info which can be used to get the control and memory for creating new nodes. But during optimization, the jvm state info may be missing like the situation in PhaseVector::optimize_vector_boxes or Macro Expansion.
> 
> JVM state is irrelevant here (otherwise, `VectorUnbox` node would have captured relevant info during construction). What is actually missing is `GraphKit` instance lacks info about control and memory. You need to explicitly set it using `GraphKit::set_control()` and `GraphKit::set_all_memory()`.

Thank you for the explanation. @iwanowww 

> We need this patch to be based on the JDK 16 repository.
> 
> I will help out with the fix-request and sponsor-ship.

Thank you very much. @neliasso 
I have create a new patch based on JDK16 repo: https://github.com/openjdk/jdk16/pull/139

-------------

PR: https://git.openjdk.java.net/jdk/pull/2253


More information about the hotspot-compiler-dev mailing list