[jdk16] RFR: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled

Vladimir Ivanov vlivanov at openjdk.java.net
Sat Jan 30 18:06:49 UTC 2021


On Sat, 30 Jan 2021 12:02:25 GMT, 王超 <github.com+25214855+casparcwang at openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/JDK-8260473
> 
> Function "PhaseVector::expand_vunbox_node" creates a LoadNode, but forgets to make the LoadNode to pass gc barriers.
> 
> Testing: all Vector API related tests have passed.
> 
> Original pr: https://github.com/openjdk/jdk/pull/2253

Overall, looks good.

test/hotspot/jtreg/compiler/vectorapi/VectorRebracket128Test.java line 47:

> 45:  * @modules java.base/jdk.internal.vm.annotation
> 46:  * @run testng/othervm -XX:CompileCommand=compileonly,jdk/incubator/vector/ByteVector.fromByteBuffer
> 47:  *      -XX:-TieredCompilation -XX:CICompilerCount=1 -XX:+UseZGC -Xbatch -Xmx256m VectorRebracket128Test

Why `-XX:CICompilerCount=1` and `-Xmx256m` are needed?

-------------

Marked as reviewed by vlivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/139


More information about the hotspot-compiler-dev mailing list