[jdk17] RFR: 8269568: JVM crashes when running VectorMask query tests [v2]

Xiaohong Gong xgong at openjdk.java.net
Thu Jul 1 07:48:46 UTC 2021


On Tue, 29 Jun 2021 16:31:27 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Refactor VectorMask query tests
>>  - Fix x86 backend codegen issue
>
> IIRC we wrote them as smoke tests because they were not intrinsic. We need to think more carefully about converting them from smoke tests.
> 
> Ideally we should convert them to kernel tests, but that is more work. Instead we can copy the generated pattern and do the following:
> 
> - move the assertion outside of the loops (it will generate garbage with string concatenation)
> - assert over arrays, thereby also moving the actual scalar computation result outside the loops. The simplest approach is to create an `int[] array` of the same length as the input and write the reduced result at index `i`. Thus it's sparse.
> 
> That should result in an inner loop body that is very focused on exercising the intrinsic method. It will also likely reduce the test execution times.

@PaulSandoz , I'v updated the tests part. Could you please check again whether it make sense to you? Thanks so much!

-------------

PR: https://git.openjdk.java.net/jdk17/pull/168


More information about the hotspot-compiler-dev mailing list