[jdk17] Integrated: 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998
Aleksey Shipilev
shade at openjdk.java.net
Thu Jul 1 09:31:06 UTC 2021
On Tue, 29 Jun 2021 09:01:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> See the bug report for more details.
>
> I believe the [JDK-8191998](https://bugs.openjdk.java.net/browse/JDK-8191998) change introduced a slight regression, where the speculative type join may empty the type. It would then crash on assert in `fastdebug` builds, or miscompile the null-check to `true` in `release` bits. New test captures both failure modes.
>
> This is not a recent regression, but a regression nevertheless, so I would like to have that fix in JDK 17. Please review carefully, or speak up if you want to move it to JDK 18+ and then backport later.
>
> Additional testing:
> - [x] New test fails without the patch, passes with it
> - [x] Linux x86_64 `fastdebug` `tier1`
This pull request has now been integrated.
Changeset: c16d1fc9
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.java.net/jdk17/commit/c16d1fc9810d5b2c112d35f3298513f86f84f66d
Stats: 63 lines in 2 files changed: 61 ins; 0 del; 2 mod
8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998
Reviewed-by: kvn, iveresov, vlivanov
-------------
PR: https://git.openjdk.java.net/jdk17/pull/169
More information about the hotspot-compiler-dev
mailing list