RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

[Coleen Phillimore]

On Thu, 1 Jul 2021 16:14:22 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Rename vm_exit_on_thread_allocation_failure to vm_exit_on_osthread_failure
>>  - Adjust comment
>>  - Comments from PR review:
>>    - remove unnecessary new_thread NULL checks
>>    - adjust some comments
>>    - fix whitespace
>
> src/hotspot/share/compiler/compileBroker.cpp line 909:
> 
>> 907:   // JavaThread due to lack of resources. We will handle that failure below.
>> 908: 
>> 909:   if (new_thread->osthread() != NULL) {
> 
> I think you do need to check `new_thread != NULL` here to please Parfait for `default:` case.

Really?  We have this sort of code everywhere.  We don't check the result of a new expression anywhere else.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4629