RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

David Holmes dholmes at openjdk.java.net
Thu Jul 1 22:12:06 UTC 2021


On Thu, 1 Jul 2021 12:07:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Rename vm_exit_on_thread_allocation_failure to vm_exit_on_osthread_failure
>>  - Adjust comment
>>  - Comments from PR review:
>>    - remove unnecessary new_thread NULL checks
>>    - adjust some comments
>>    - fix whitespace
>
> src/hotspot/share/runtime/thread.cpp line 3910:
> 
>> 3908:                                        Handle thread_oop, ThreadPriority prio) {
>> 3909:   MutexLocker mu(current, Threads_lock);
>> 3910: 
> 
> Could you add an assert that target->os_thread() != NULL here?  Just to make sure everything checked.

Done

-------------

PR: https://git.openjdk.java.net/jdk/pull/4629


More information about the hotspot-compiler-dev mailing list