RFR: 8267982: Set the node after peephole optimization to be removed [v9]

[Tobias Hartmann]

On Fri, 25 Jun 2021 03:07:30 GMT, SUN Guoyun <github.com+40024232+sunny868 at openjdk.org> wrote:

>> Hi all,
>> 
>> Enable peephole can cause SIGSEGV sometimes in OopFlow::build_oop_map(Node*, int, PhaseRegAlloc*, int*)+0x238 , so must set a removed-flags for the peephole-nodes , to avoid be set-live-bit() and cause crash.
>>  Please review this trivial change.
>> 
>> Thanks,
>> Sun Guoyun
>
> SUN Guoyun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8267982: Set the node after peephole optimization to be removed

Otherwise, it looks good to me.

src/hotspot/share/opto/machnode.hpp line 380:

> 378:   virtual bool is_TrapBasedCheckNode() const { return false; }
> 379:   void set_removed(){ _removed = true; }
> 380:   bool get_removed(){ return _removed; }

Please add whitespaces:
`set_removed() {`
`get_removed() {`

-------------

Changes requested by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4276