[jdk17] Integrated: 8269568: JVM crashes when running VectorMask query tests

Xiaohong Gong xgong at openjdk.java.net
Tue Jul 6 08:20:56 UTC 2021


On Tue, 29 Jun 2021 08:56:44 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

> This is a follow-up patch for [1]. When we are trying to add the VectorMask query implementation for Arm NEON, we found the jtreg tests for `VectorMask.trueCount/firstTrue/lastTrue` is not effective. The tests failure cannot be reported as expected. The main reason is that the Vector API methods are not hot enough to be compiled by C2 compiler. Wrap the main test codes inside a loop can make the tests effective.
> 
> With the tests taking effect, we can see a JVM crash due to the following assertion:
> 
>   vector/src/hotspot/share/opto/vectornode.hpp:879), pid=168241, tid=168257
>   # Error: assert(mask->Opcode() == Op_VectorStoreMask) failed
> 
> The mask input might be other vector nodes like `"LoadVectorNode"`, since there is an optimization for `"VectorStoreMask"`:
> 
>   VectorStoreMask (VectorLoadMask value) ==> value
> 
> Changing the code to check whether its element basic type is `"T_BOOLEAN"` is more reasonable.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8256973

This pull request has now been integrated.

Changeset: 2b207782
Author:    Xiaohong Gong <xgong at openjdk.org>
Committer: Jie Fu <jiefu at openjdk.org>
URL:       https://git.openjdk.java.net/jdk17/commit/2b20778225527a3ccd3ced2a4246c5943f467e06
Stats:     2298 lines in 34 files changed: 1491 ins; 341 del; 466 mod

8269568: JVM crashes when running VectorMask query tests

Co-authored-by: Sandhya Viswanathan <sviswanathan at openjdk.org>
Reviewed-by: psandoz, jiefu, jbhateja, sviswanathan

-------------

PR: https://git.openjdk.java.net/jdk17/pull/168


More information about the hotspot-compiler-dev mailing list