RFR: JDK-8270147: Increase stride size allowing unrolling more loops [v2]
Radoslaw Smogura
github.com+7535718+rsmogura at openjdk.java.net
Mon Jul 12 19:04:26 UTC 2021
On Sun, 11 Jul 2021 21:06:45 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Radoslaw Smogura has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Drop whitespace, again.
>> - Set maximum stride size to be 1 << 2 or max vector size
>>
>> Keep overflow test if stride can overflow when doubling
>> Drop diagnostic flag
>
> src/hotspot/share/opto/loopTransform.cpp line 2010:
>
>> 2008: // Verify that unroll policy result is still valid.
>> 2009: assert(old_trip_count > 1 && (!adjust_min_trip || stride_p <=
>> 2010: MIN2(max_jint / 2 - 2, MAX2(1<<2, Matcher::max_vector_size(T_BYTE)) * loop_head->unrolled_count())), "sanity");
>
> Should be `1<<3` here. Otherwise looks good.
Thank you, fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4658
More information about the hotspot-compiler-dev
mailing list