RFR: 8269725: AArch64: Add VectorMask query implementation for NEON [v5]

Xiaohong Gong xgong at openjdk.java.net
Wed Jul 14 10:36:12 UTC 2021


On Wed, 14 Jul 2021 10:19:17 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/aarch64.ad line 1320:
>> 
>>> 1318:     const TypeVect* vt = def->bottom_type()->is_vect();
>>> 1319:     return vt->length();
>>> 1320:   }
>> 
>> There doesn't seem to be anything AArch64-specific about these functions. I guess if no-one else uses them they can go in aarch64.ad, but it doesn't seem to make much sense.
>
> Yes, actually they are not AAch64-specific. Besides AArch64, x86 also defines the same methods in `x86.ad` and they are used widely in there match rules.

Since this change will touch the x86 codes, do you think it's better to create a followed-up patch to remove the shared methods?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4699


More information about the hotspot-compiler-dev mailing list