RFR: 8270366: C2: Add associative rule to add/sub node [v2]
Christian Hagedorn
chagedorn at openjdk.java.net
Wed Jul 14 15:58:14 UTC 2021
On Wed, 14 Jul 2021 14:04:41 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
>> Please review this small patch that add associative rule to add/sub node, that eliminates a multiply instruction.
>>
>> e.g.
>>
>> private static int assocInt(int a, int b, int c) {
>> return a * c + b * c;
>> }
>>
>>
>> x86_64:
>> Before:
>>
>> 0x00007fda1506152c: imul %ecx,%esi
>> 0x00007fda1506152f: imul %ecx,%edx
>> 0x00007fda15061532: mov %esi,%eax
>> 0x00007fda15061534: add %edx,%eax ;*iadd {reexecute=0 rethrow=0 return_oop=0}
>> ; - TestAssoc::assocInt at 6 (line 9)
>>
>>
>> After:
>>
>> 0x00007fc1c078d52c: add %edx,%esi
>> 0x00007fc1c078d52e: mov %ecx,%eax
>> 0x00007fc1c078d530: imul %esi,%eax ;*iadd {reexecute=0 rethrow=0 return_oop=0}
>> ; - TestAssoc::assocInt at 6 (line 9)
>
> Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Missing case pointed out by Andrew Dinn
> - Merge branch 'master' into JDK-8270366-associative
> - sub
> - add
This RFE would also be well suited for using the new [IR framework](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/ir_framework/README.md) to create an IR test to verify the new IR transformations.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4765
More information about the hotspot-compiler-dev
mailing list