RFR: 8269725: AArch64: Add VectorMask query implementation for NEON [v5]

Xiaohong Gong xgong at openjdk.java.net
Thu Jul 15 07:19:13 UTC 2021


On Thu, 15 Jul 2021 07:06:03 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> @theRealAph , seems the `__ movw` in line-5354 is still needed since the `vector_length` is also used in the next instruction `__ cselw($dst$$Register, rscratch1, $dst$$Register, Assembler::GE);`. It is used to decide the final result.
>
> So it is, you're right. Sorry.

Never mind. I also forgot the last instruction yesterday! Thanks all the time for the suggestion!

>> The main reason is the argument difference that `vmask_firsttrue_LT8B` needs to clear the `rFlagsReg` while `vmask_firsttrue8B`. It doesn't matter too much if the rule always clear the flag, right?
>
> It doesn't much matter, no, but being able to make differences like this without cut-and-paste programming is why we have a macro processor. Your call.

So for this part, do you mean it's ok if we can just merge the codes in m4 file while not in the ad file? Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4699


More information about the hotspot-compiler-dev mailing list