RFR: 8271140: Fix native frame handling in vframeStream::asJavaVFrame() [v2]
Andreas Woess
aw at openjdk.java.net
Sun Jul 25 01:01:22 UTC 2021
On Fri, 23 Jul 2021 02:30:53 GMT, Andreas Woess <aw at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/jvmci/compilerToVM/IterateFramesNative.java line 47:
>>
>>> 45: * -XX:+DoEscapeAnalysis -XX:-UseCounterDecay
>>> 46: * compiler.jvmci.compilerToVM.IterateFramesNative
>>> 47: * @run main/othervm -Xbatch -Xcomp -Xbootclasspath/a:.
>>
>> I think `-Xcomp` implies `-Xbatch`.
>> I think you should add `-XX:CompileOnly=jdk.vm.ci.hotspot.CompilerToVM::iterateFrames` since you only really care about that method being compiled for sake of the test.
>
> Hm, actually, I don't really need to use `-Xcomp` since the test should already trigger compilation anyway. It was just a way to ensure it's really compiled. I'll replace it with an assert in the test that the method is compiled.
Reverted to using `-Xcomp` but with `-XX:CompileOnly`. Some configurations did not trigger compilation in the expected iteration; I've probably just got the threshold wrong, but I think the `-Xcomp` solution is less fragile and thus preferable.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4872
More information about the hotspot-compiler-dev
mailing list