RFR: 8271140: Fix native frame handling in vframeStream::asJavaVFrame() [v2]
Vladimir Kozlov
kvn at openjdk.java.net
Mon Jul 26 19:42:38 UTC 2021
On Sun, 25 Jul 2021 01:01:21 GMT, Andreas Woess <aw at openjdk.org> wrote:
>> Follow-up to https://github.com/openjdk/jdk/pull/4625 ([JDK-8269592](https://bugs.openjdk.java.net/browse/JDK-8269592)) which added support for native frames to `vframeStreamCommon::asJavaVFrame()`. This change was not correct when `asJavaVFrame()` is called for a native frame that is the last frame on the stack (i.e. the first frame in the stream), in which case there's no `_prev_frame` yet. We don't actually need the extended frame information for native frames, so the fix is to just use the vframeStream's `_frame` and `_reg_map` for native frames.
>> Extended the test from JDK-8269592 to cover this case.
>
> Andreas Woess has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> 8271140: Fix native frame handling in vframeStream::asJavaVFrame()
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4872
More information about the hotspot-compiler-dev
mailing list