RFR: 8270901: Typo PHASE_CPP in CompilerPhaseType [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Jul 28 15:48:36 UTC 2021


On Wed, 28 Jul 2021 08:38:04 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> For hotspot changes, it would be better to have a second review & wait for 24 hours before integration. 
>> Thanks.
>
>> For hotspot changes, it would be better to have a second review & wait for 24 hours before integration.
>> Thanks.
> 
> Well, it seems a trivial change, maybe one review is okay. For non-trivial changes, we really need more reviews and wait for 24h before merging.

@kelthuzadx - HotSpot changes require two reviews and a 24 hour waiting period.
You may propose in your review request that a change is "trivial" and if your
(R)eviewer agrees, then you may integrate with a single (R)eviewer and you don't
have to wait for 24 hours.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4917


More information about the hotspot-compiler-dev mailing list