RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v4]
    Valerie Peng 
    valeriep at openjdk.java.net
       
    Fri Jul 30 18:56:40 UTC 2021
    
    
  
On Thu, 22 Jul 2021 17:16:45 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
>> Seems strange to have GCMOperation op defined in GCMEngine but not initialized, nor used. The methods in GCMEngine which use op has an argument named op anyway. Either you just use the "op" field (remove the "op" argument) or the "op" argument (move the op field to GCMEncrypt/GCMDecrypt class). Having both looks confusing.
>
> Ok.. Moving it into GCMEncrypt makes sense.  Now that I look at the code GCMDecrypt only uses it when passed to a method.  GCMEncrypt uses it
This is still present in the latest update. Is there another update coming?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4019
    
    
More information about the hotspot-compiler-dev
mailing list