RFR: 8271461: CompileCommand support for hidden class methods [v3]

Jie Fu jiefu at openjdk.java.net
Sat Jul 31 00:12:28 UTC 2021


On Fri, 30 Jul 2021 23:56:24 GMT, Xin Liu <xliu at openjdk.org> wrote:

> I start from -XX::CompileCommand=help, double colon seems an back-compatibility format.
> 
> ```
> Method patterns has the format:
>   package/Class.method()
> 
> For backward compatibility this form is also allowed:
>   package.Class::method()
> 
> The signature can be separated by an optional whitespace or comma:
>   package/Class.method ()
> ```
> 
> I guess you can factor out this and reuse it.
> 
> ```
> char next = *(lp + 1);
> if (isdigit(next) || next == '*') {
> // May be a hidden class method, so replace '/' with '+'
>  *lp = '+';
> ```
> 
> Anyway, it's optional if it increases complexity . The current solution is good for me. I think it's useful! I am not a reviewer. Still need a second reviewer to approve.

Thanks @navyxliu .

Let's see what the reviewers think of it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4926


More information about the hotspot-compiler-dev mailing list