RFR: JDK-8267930: Refine code for loading hsdis library [v4]

Nils Eliasson neliasso at openjdk.java.net
Tue Jun 1 06:55:19 UTC 2021


On Tue, 1 Jun 2021 01:49:37 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> code for loading hsdis library is redundant, this is to simplify it.
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - use jio_snprintf instead of strcpy and strcat
>  - use jio_snprintf instead of strcpy and strcat

src/hotspot/share/compiler/disassembler.cpp line 758:

> 756: // You can call the decode_env methods directly if you already have one.
> 757: 
> 758: void* Disassembler::dll_load(char* buf, int offset, int buflen, char* ebuf, int ebuflen, outputStream* st) {

Please change the argument order - so that the lengths comes directly after the buffers. Like this:
Disassembler::dll_load(char* buf, int buflen, int offset, char* ebuf, int ebuflen, outputStream* st)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4260


More information about the hotspot-compiler-dev mailing list