RFR: 8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly [v2]

[Tobias Hartmann]

On Mon, 31 May 2021 15:06:56 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Hi,
>> 
>> PhaseStringOpts::int_stringSize doesn't handle min_jint correctly - it can't be negated to a positive number. I fix this adding a special case for this.
>> 
>> Added a test that was contributed by Adam who reported the bug. Will add as a contributor.
>> 
>> Please review,
>> Best regards,
>> Nils Eliasson
>
> Nils Eliasson has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove test
>  - Add and fix test

Looks good to me, thanks for fixing!

What about the "wrong type in PhaseStringOpts::fetch_static_field" you mentioned in the bug comments?

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4255